This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Merged
Conversation
…l, will set dynamically via theme later
…de of game itself
Closed
There was a problem hiding this comment.
Pull Request Overview
Implements a dark mode feature with a unique purple color scheme and removes the grid visual clutter from the game visualizer. The PR includes a complete theme system with light/dark mode toggle functionality, keyboard shortcuts, and persistent theme preferences.
- Adds a comprehensive dark/light theme system with CSS custom properties
- Removes grid visual styling while keeping grid cells for functionality
- Implements theme persistence and keyboard shortcuts for mode switching
Reviewed Changes
Copilot reviewed 10 out of 39 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ts/input_manager/themeManager.ts | New theme management system with toggle functionality and persistence |
| src/css/styles.css | Complete theme system implementation with CSS custom properties for both modes |
| index.html | Updated HTML structure with theme toggle button and improved layout |
| src/ts/main.ts | Integration of theme loading on page initialization |
| src/ts/input_manager/timeManager.ts | Added keyboard shortcuts for theme switching (d/l keys) |
| src/ts/renderer/renderer.ts | Updated grid styling and tooltip positioning format |
| src/ts/replay_loader/object.ts | Changed hardcoded colors to CSS custom properties |
| src/ts/renderer/objectRenderer.ts | Added CSS class for game objects to support theme-based styling |
| package.json | Added CSS files to linting configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Here is what the updated visuals look like |
Member
Author
|
Forgot about this earlier, just added a detection for the users color scheme. It runs in the html header so it runs before any html is even loaded to prevent accidental flashes of the wrong color scheme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark mode works is here and is nice and unique looking with a dark purple instead of a generic dark grey. I think it looks good.
I also removed the grid though. @flomero how is the grid actually useful information though? When you view it on the replay eyeballing it is enough so you can gage how long walking somewhere will take. If you want details you can hover. How is knowing exactly what is in what row even helpful?
But what we gain is way less visual clutter. I think it looked significantly worse before. It makes the completely irrelevant gridlines a visually distracting focus.
If you don't think we should keep it as it is on this branch, what actual info do you gain from the gridlines? How is it benefitial to a good visualizer? I don't get it.